Extend CI to verify editable, non-editable, and GitHub install methods by Copilot · Pull Request #52 · AMDResearch/intellikit

Copilot · 2026-02-18T18:55:17Z

Plan: Extend CI to verify all supported install methods

Summary

Extended CI to verify all three supported install methods (editable, non-editable, and GitHub) using a matrix strategy for better maintainability.

Changes Made

Implementation Details

Single test job with matrix strategy:

Matrix dimensions: 6 packages × 3 install methods = 18 test combinations
Packages: accordo, linex, metrix, nexus, rocm_mcp, uprof_mcp
Install methods: editable, non-editable, github
fail-fast: false ensures all combinations run even if one fails
Matrix key uses underscore (install_method) for proper GitHub Actions expression evaluation

Install methods tested:

Editable: pip install -e <package>
Non-editable: pip install ./<package>
GitHub: pip install git+https://github.com/AMDResearch/intellikit.git@sha#subdirectory=<package>

Import verification:

Each install is followed by python3 -c 'import <package>' to verify correct installation

GitHub install improvements:

Fixed quoting: Changed from double quotes to single quotes around git URLs to prevent shell interpolation issues when passed through container_exec.sh
Fixed SHA handling: Use github.event.pull_request.head.sha for pull requests instead of github.sha (which is a synthetic merge commit SHA that may not be fetchable)

Isolation:

Each test step runs in isolated container overlay (via container_exec.sh)
Ensures no contamination between tests

Security:

Minimal workflow permissions (contents: read) following security best practices
CodeQL scan passed with 0 alerts

Original prompt

This section details on the original issue you should resolve

<issue_title>Extend CI to verify all supported install methods so we catch packaging/import issues (e.g. flat vs src layout, non-editable vs editable).</issue_title>
<issue_description>## Summary
Extend CI to verify all supported install methods so we catch packaging/import issues (e.g. flat vs src layout, non-editable vs editable).

Install methods to test

Editable – pip install -e accordo (and same for linex, metrix, nexus) from repo root; then python3 -c 'import accordo' (and equivalents).

Non-editable – pip install . (or pip install ./accordo, etc.) then the same import checks.

From GitHub – pip install git+https://github.com/AMDResearch/intellikit.git#subdirectory=accordo (and equivalents for other packages / root) then import checks.

Rationale

Editable works today; non-editable can fail (e.g. scikit-build-core / mixed CMake+Python).

Installing from GitHub ensures the published install path works for users.

Running all three in CI will prevent regressions when changing layout or build config.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Extend CI to verify all supported install methods so we catch packaging/import issues (e.g. flat vs src layout, non-editable vs editable). #51

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

.github/workflows/intellikit-ci-test.yml

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

Copilot

Pull request overview

Extends the existing “Intellikit CI Test” GitHub Actions workflow to validate that each subpackage can be installed and imported via all supported installation methods (editable, non-editable, and GitHub VCS install), using a matrix strategy.

Changes:

Add minimal GITHUB_TOKEN permissions (contents: read) to the workflow.
Refactor installation/import verification into a matrix over packages × install methods.
Add a GitHub VCS install path (pip install git+https://...#subdirectory=...) to exercise “install from GitHub” behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

.github/workflows/intellikit-ci-test.yml

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

.github/workflows/intellikit-ci-test.yml

mawad-amd · 2026-03-03T22:59:39Z

@copilot apply changes based on the comments in this thread

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

Copilot · 2026-03-03T23:02:03Z

@copilot apply changes based on the comments in this thread

Applied all changes from the review thread:

Fixed matrix key naming: install-method → install_method (hyphens cannot be used with dot notation in GitHub Actions)
Updated all references to use the corrected key name in job names, step names, and conditionals
Added root to the matrix to test the top-level project installation for all three install methods (validates scikit-build-core/CMake and dependency wiring)

The matrix now runs 21 combinations (7 packages × 3 install methods). Root project tests skip import verification since there's no top-level module to import. Commit: 36a8676

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

.github/workflows/intellikit-ci-test.yml

mawad-amd · 2026-03-03T23:38:24Z

@copilot apply changes based on the comments in this thread

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

Copilot · 2026-03-03T23:41:08Z

@copilot apply changes based on the comments in this thread

Applied all changes from the review thread:

Fixed quoting in GitHub install commands: Changed from double quotes (\"...\") to single quotes ('...') around git URLs to prevent shell interpolation issues when passed through container_exec.sh's bash -c command
Fixed SHA handling for pull requests: Now uses github.event.pull_request.head.sha for PRs instead of github.sha (which is a synthetic merge commit SHA that isn't fetchable via git+https)
Applied proper variable interpolation using ${GIT_SHA} instead of direct GitHub expression in URLs

The workflow now correctly handles both push events and pull requests, and the git URLs are properly quoted to survive the nested bash execution. Commit: 51d9854

.github/workflows/intellikit-ci-test.yml

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

mawad-amd · 2026-03-03T23:57:30Z

@cursoragent any comments on this pr?

Initial plan

c17bebe

Copilot AI assigned Copilot and mawad-amd Feb 18, 2026

Copilot started work on behalf of mawad-amd February 18, 2026 18:56 View session

Copilot AI and others added 2 commits February 18, 2026 18:57

Add CI tests for non-editable and GitHub installs

a713e2b

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

Add security: set minimal workflow permissions

db6c1ba

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

mawad-amd reviewed Feb 18, 2026

View reviewed changes

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

Copilot AI changed the title ~~[WIP] Extend CI to verify all supported install methods~~ Extend CI to verify editable, non-editable, and GitHub install methods Feb 18, 2026

Copilot AI requested a review from mawad-amd February 18, 2026 19:03

Copilot finished work on behalf of mawad-amd February 18, 2026 19:03

Copilot started work on behalf of mawad-amd February 18, 2026 19:03 View session

Refactor CI to use matrix strategy for install methods

2ecfced

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

Copilot finished work on behalf of mawad-amd February 18, 2026 19:06

mawad-amd marked this pull request as ready for review March 3, 2026 22:30

Copilot AI review requested due to automatic review settings March 3, 2026 22:30

Copilot started reviewing on behalf of mawad-amd March 3, 2026 22:31 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

Apply suggestions from code review

53b780a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

mawad-amd requested a review from Copilot March 3, 2026 22:51

Copilot started reviewing on behalf of mawad-amd March 3, 2026 22:52 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

Copilot started work on behalf of mawad-amd March 3, 2026 23:00 View session

Fix matrix key naming and add root project tests

36a8676

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

mawad-amd requested a review from Copilot March 3, 2026 23:02

Copilot finished work on behalf of mawad-amd March 3, 2026 23:02

Copilot started reviewing on behalf of mawad-amd March 3, 2026 23:03 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

Copilot started work on behalf of mawad-amd March 3, 2026 23:39 View session

Fix quoting and SHA handling for GitHub installs

51d9854

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

Copilot finished work on behalf of mawad-amd March 3, 2026 23:41

mawad-amd reviewed Mar 3, 2026

View reviewed changes

.github/workflows/intellikit-ci-test.yml Outdated Show resolved Hide resolved

Copilot started work on behalf of mawad-amd March 3, 2026 23:43 View session

Remove root project testing from matrix

2174af5

Co-authored-by: mawad-amd <112003944+mawad-amd@users.noreply.github.com>

Copilot finished work on behalf of mawad-amd March 3, 2026 23:45

Copilot AI requested a review from mawad-amd March 3, 2026 23:45

mawad-amd merged commit c8afc5f into main Mar 4, 2026
22 checks passed

mawad-amd deleted the copilot/extend-ci-install-methods-testing branch March 4, 2026 00:08

Conversation

Copilot AI commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan: Extend CI to verify all supported install methods

Summary

Changes Made

Implementation Details

Install methods to test

Rationale

Comments on the Issue (you are @copilot in this section)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mawad-amd commented Mar 3, 2026

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mawad-amd commented Mar 3, 2026

Uh oh!

Copilot AI commented Mar 3, 2026

Uh oh!

Uh oh!

mawad-amd commented Mar 3, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Feb 18, 2026 •

edited

Loading